search

yegor256 / cactoos-http

Object-Oriented HTTP Client
MIT License
37 stars 28 forks source link

(#83) Moving Get to main package #91

Closed scristalli closed 5 years ago

scristalli commented 5 years ago

This is for #83.

As requested in the issue, I moved the Get class from the test package to the main package.

0crat commented 5 years ago

@scristalli/z this pull request is too small, just 0 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @llorllale/z please review this and merge or reject

llorllale commented 5 years ago

@scristalli missing tests for this class

codecov-io commented 5 years ago

Codecov Report

Merging #91 into master will increase coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #91      +/-   ##
============================================
+ Coverage     95.02%   95.12%   +0.09%     
- Complexity       74       75       +1     
============================================
  Files            19       20       +1     
  Lines           201      205       +4     
  Branches         13       13              
============================================
+ Hits            191      195       +4     
  Misses            7        7              
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/http/Get.java 100% <ø> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19720b8...b97467d. Read the comment docs.

scristalli commented 5 years ago

@llorllale I added a test case (only one since there is only the constructor to test)

llorllale commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

0crat commented 5 years ago

Job gh:yegor256/cactoos-http#91 is not assigned, can't get performer

0crat commented 5 years ago

This job is not in scope