search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1335) LengthOf is now just a Scalar of Long #1535

Closed victornoel closed 3 years ago

victornoel commented 3 years ago

First step of #1335: LengthOf is not a Number anymore

0crat commented 3 years ago

This pull request #1535 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

victornoel commented 3 years ago

@baudoliver7 We need to wait for https://github.com/llorllale/cactoos-matchers/pull/221 and then https://github.com/yegor256/cactoos/issues/1531 for this to be able to build. I will ping you back when it's ok :)

baudoliver7 commented 3 years ago

@victornoel Ok

baudoliver7 commented 3 years ago

@victornoel I'm always waiting :)

victornoel commented 3 years ago

@baudoliver7 I know, I haven't forgot, this nor any of the other opened PRs

baudoliver7 commented 3 years ago

@victornoel Just to remind you that if code review takes too long time, you will be exposed to penalties as ARC §55

victornoel commented 3 years ago

@0crat refuse

victornoel commented 3 years ago

@baudoliver7 I know, if I were paid, maybe I would worry about it :) I've removed you from this job and will add you again once it's ready to be reviewed. I am waiting for another ticket to be solved first

0crat commented 3 years ago

@0crat refuse (here)

@victornoel The user @baudoliver7/z resigned from #1535, please stop working. Reason for job resignation: Order was cancelled

baudoliver7 commented 3 years ago

@victornoel Good ! Don't hesitate to assign it to me again when all things are ready :)

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1535; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1535; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

victornoel commented 3 years ago

Closing this, even with #1531 it's not building, we will have to wait for llorllale/cactoos-matchers#220 to be fixed first

0crat commented 3 years ago

Job gh:yegor256/cactoos#1535 is not assigned, can't get performer

0crat commented 3 years ago

Pull request #1535 was not merged, no payment for ARC, see §28