search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

#1464 Add iterator.Paged and remove checkstyle suppression #1536

Closed baudoliver7 closed 3 years ago

baudoliver7 commented 3 years ago

1464

codecov-io commented 3 years ago

Codecov Report

Merging #1536 (86ad37b) into master (1fed966) will not change coverage. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1536   +/-   ##
=========================================
  Coverage     90.83%   90.83%           
- Complexity     1555     1558    +3     
=========================================
  Files           284      285    +1     
  Lines          3668     3668           
  Branches        125      123    -2     
=========================================
  Hits           3332     3332           
  Misses          306      306           
  Partials         30       30
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/iterable/Paged.java 100.00% <ø> (+14.28%) 1.00 <0.00> (-1.00) :arrow_up:
src/main/java/org/cactoos/iterator/Paged.java 83.33% <83.33%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fed966...86ad37b. Read the comment docs.

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1536; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

baudoliver7 commented 3 years ago

@victornoel PR done

baudoliver7 commented 3 years ago

@victornoel Some changes have been made

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1536; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

baudoliver7 commented 3 years ago

@victornoel Some changes have been made.

victornoel commented 3 years ago

@baudoliver7 great, thx

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

0crat commented 3 years ago

Job gh:yegor256/cactoos#1536 is not assigned, can't get performer