yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
741 stars 166 forks source link

(#906) Implements RangeOf for iterator #1542

Closed baudoliver7 closed 3 years ago

baudoliver7 commented 3 years ago

906

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1542; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

victornoel commented 3 years ago

@0crat assign me

codecov-io commented 3 years ago

Codecov Report

Merging #1542 (f04c531) into master (ad78315) will increase coverage by 0.00%. The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1542   +/-   ##
=========================================
  Coverage     90.90%   90.90%           
- Complexity     1571     1574    +3     
=========================================
  Files           291      292    +1     
  Lines          3694     3696    +2     
  Branches        123      121    -2     
=========================================
+ Hits           3358     3360    +2     
  Misses          306      306           
  Partials         30       30           
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/iterable/RangeOf.java 100.00% <ø> (+18.18%) 1.00 <0.00> (-1.00) :arrow_up:
src/main/java/org/cactoos/iterator/RangeOf.java 81.81% <81.81%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad78315...f04c531. Read the comment docs.

baudoliver7 commented 3 years ago

@victornoel Some changes have been made.

baudoliver7 commented 3 years ago

@victornoel I think that things are good now :)

victornoel commented 3 years ago

@baudoliver7 hehe thx

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 10min)

0crat commented 3 years ago

Job was finished in 4 hours, bonus for fast delivery is possible (see §36)