yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1531) Bump cactoos-matchers to 0.24 #1543

Closed victornoel closed 3 years ago

victornoel commented 3 years ago

Bump cactoos-matchers to latest version, use Verifies instead of MatcherOf and replace Joined by Concatenated when possible.

codecov-io commented 3 years ago

Codecov Report

Merging #1543 (19b8a01) into master (7a7e221) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1543      +/-   ##
============================================
- Coverage     90.90%   90.85%   -0.06%     
+ Complexity     1574     1569       -5     
============================================
  Files           292      292              
  Lines          3696     3696              
  Branches        121      121              
============================================
- Hits           3360     3358       -2     
- Misses          306      308       +2     
  Partials         30       30              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/io/TempFolder.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
src/main/java/org/cactoos/text/Capitalized.java 100.00% <100.00%> (ø) 5.00 <1.00> (ø)
src/main/java/org/cactoos/text/PaddedStart.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
src/main/java/org/cactoos/text/UncheckedText.java 81.81% <0.00%> (-9.10%) 10.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a7e221...19b8a01. Read the comment docs.

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 3 years ago

@baudoliver7 see my answers and changes, thx

baudoliver7 commented 3 years ago

@victornoel thx, looks good to me :)

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

0crat commented 3 years ago

Job was finished in 19 hours, bonus for fast delivery is possible (see §36)

0crat commented 3 years ago

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 3 years ago

@0crat quality good