search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1498) Added 'text.Newline' #1551

Closed dearrudam closed 3 years ago

dearrudam commented 3 years ago

1498

andreoss commented 3 years ago

@dearrudam Btw, it seems that you have incorrect git settings, the commits in these are not identified as done by you

dearrudam commented 3 years ago

@dearrudam Btw, it seems that you have incorrect git settings, the commits in these are not identified as done by you

@andreoss , I'm so sorry! I forgot to change the git settings for this repo on the laptop that I'm using with.

andreoss commented 3 years ago

@dearrudam You can easily fix it by ameding your commits.

codecov-io commented 3 years ago

Codecov Report

Merging #1551 (c5796bd) into master (ffe6721) will decrease coverage by 0.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1551      +/-   ##
============================================
- Coverage     90.85%   90.59%   -0.26%     
- Complexity     1567     1570       +3     
============================================
  Files           291      295       +4     
  Lines          3694     3709      +15     
  Branches        121      121              
============================================
+ Hits           3356     3360       +4     
- Misses          308      318      +10     
- Partials         30       31       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/text/Newline.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/main/java/org/cactoos/text/TextOf.java 72.46% <0.00%> (-11.01%) 25.00% <0.00%> (-28.00%)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/map/Merged.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/main/java/org/cactoos/text/TextOfScalar.java 92.30% <0.00%> (ø) 8.00% <0.00%> (?%)
src/main/java/org/cactoos/text/TextOfDateTime.java 100.00% <0.00%> (ø) 23.00% <0.00%> (?%)
src/main/java/org/cactoos/text/TextOfString.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffe6721...c5796bd. Read the comment docs.

victornoel commented 3 years ago

@dearrudam thank you, I will let @andreoss finish his review now :)

dearrudam commented 3 years ago

@dearrudam thank you, I will let @andreoss finish his review now :)

@victornoel and @andreoss, thanks, guys! I'm learning a lot!

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

0crat commented 3 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 3 years ago

@dearrudam please make sure you start all your comments with the name of the user they are refereed to, see

sereshqua commented 3 years ago

@0crat quality acceptable

dearrudam commented 3 years ago

@dearrudam please make sure you start all your comments with the name of the user they are refereed to, see

@sereshqua thanks for letting me know that! I'll pay attention to it next time! I'm learning a lot, many thanks!

dearrudam commented 3 years ago

@sereshqua I'd like to know more about the quality levels that ZC uses to classify the jobs. Could you help me with it? thanks

sereshqua commented 3 years ago

@dearrudam sure, go here, it is a ZC policy