search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

For Issue #1507 #1554

Closed dearrudam closed 3 years ago

dearrudam commented 3 years ago

It's for issue #1507

dearrudam commented 3 years ago

The io.InputOfTest.readsSecureUrlContent test consumes the https://www.yegor256.com/robots.txt URL... at the moment of the test, the Tests (ubuntu-18.04, 11) container couldn't access there than broken the subsequent checks... IMHO I think that maybe it's needed to put some retry logic or maybe point to other robots.txt URLs (locally or fake or real) in order to avoid this kind of issue in the future.

codecov-io commented 3 years ago

Codecov Report

Merging #1554 (8433f06) into master (b1e5a28) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1554      +/-   ##
============================================
+ Coverage     90.61%   90.71%   +0.10%     
- Complexity     1574     1576       +2     
============================================
  Files           294      296       +2     
  Lines          3707     3717      +10     
  Branches        121      121              
============================================
+ Hits           3359     3372      +13     
+ Misses          318      314       -4     
- Partials         30       31       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/cactoos/iterable/MappedWithIndex.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...ain/java/org/cactoos/iterator/MappedWithIndex.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
...in/java/org/cactoos/iterator/IteratorEnvelope.java 75.00% <0.00%> (+16.66%) 5.00% <0.00%> (+1.00%)
src/main/java/org/cactoos/iterator/Mapped.java 100.00% <0.00%> (+18.18%) 1.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1e5a28...8433f06. Read the comment docs.

victornoel commented 3 years ago

@dearrudam thx

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

0crat commented 3 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 3 years ago

@dearrudam please make sure you start all of the comment with the name of the user they are refereed to, see

sereshqua commented 3 years ago

@0crat quality acceptable