(#1335) Introduce NumberEnvelope and move number in their package

[victornoel]

Last part of #1335: introduce NumberEnvelope and move all the Number implementations to their own packages.

Some tests were passing differently with respect to overflow and stuffs like that: I considered it was ok to change them, but I may have misunderstood their purpose. From my POV, they didn't bring anything particularly useful, but I will ask their original author in comments to review that.

This also covers #1591 and #1496 since they fitted nicely in this PR.

[victornoel]

@0crat status

[0crat]

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

• The job #1587 is in scope for 13days
• The role is REV
• The job is assigned to @andreoss/z for 13days
• There is no monetary reward attached, it's a free job
• The job doesn't have any impediments
• The budget is 15 minutes/points
• These users are banned and won't be assigned:
  • @victornoel/z: This user reported the ticket
• Job footprint (restricted area)

[victornoel]

@andreoss finally, this PR is ready to be reviewed. It's a bit big and I apologized for it, if it's too big, just tell me and I will have to break it into pieces, but if I can avoid it will be easier since there are both changes and moved classes :)

[victornoel]

@andreoss thx, I took your comments into account

[codecov-commenter]

Codecov Report

Merging #1587 (510666e) into master (a9c3bdc) will decrease coverage by 0.08%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1587      +/-   ##
============================================
- Coverage     90.16%   90.08%   -0.09%     
+ Complexity     1616     1603      -13     
============================================
  Files           302      298       -4     
  Lines          3784     3750      -34     
  Branches        121      122       +1     
============================================
- Hits           3412     3378      -34     
+ Misses          339      338       -1     
- Partials         33       34       +1     

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/Fallback.java	100.00% <ø> (ø)	0.00 <0.00> (ø)
src/main/java/org/cactoos/io/TailOf.java	100.00% <ø> (ø)	10.00 <0.00> (ø)
src/main/java/org/cactoos/iterable/IterableOf.java	95.83% <100.00%> (-0.17%)	15.00 <1.00> (-1.00)
src/main/java/org/cactoos/number/AvgOf.java	100.00% <100.00%> (ø)	6.00 <6.00> (?)
...main/java/org/cactoos/number/ComparableNumber.java	100.00% <100.00%> (ø)	2.00 <2.00> (?)
src/main/java/org/cactoos/number/DivisionOf.java	100.00% <100.00%> (ø)	4.00 <4.00> (?)
src/main/java/org/cactoos/number/MaxOf.java	100.00% <100.00%> (ø)	6.00 <4.00> (?)
src/main/java/org/cactoos/number/MinOf.java	100.00% <100.00%> (ø)	6.00 <4.00> (?)
...main/java/org/cactoos/number/MultiplicationOf.java	100.00% <100.00%> (ø)	3.00 <2.00> (?)
...c/main/java/org/cactoos/number/NumberEnvelope.java	100.00% <100.00%> (ø)	10.00 <10.00> (?)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9c3bdc...510666e. Read the comment docs.

[victornoel]

@0crat status

[victornoel]

@0crat status

[0crat]

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

• The job #1587 is in scope for 2mon
• The role is REV
• The job is assigned to @andreoss/z for 2mon
• There is no monetary reward attached, it's a free job
• The job doesn't have any impediments
• The budget is 15 minutes/points
• These users are banned and won't be assigned:
  • @victornoel/z: This user reported the ticket
• Job footprint (restricted area)

[0crat]

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

• The job #1587 is in scope for 2mon
• The role is REV
• The job is assigned to @andreoss/z for 2mon
• There is no monetary reward attached, it's a free job
• The job doesn't have any impediments
• The budget is 15 minutes/points
• These users are banned and won't be assigned:
  • @victornoel/z: This user reported the ticket
• Job footprint (restricted area)

[victornoel]

@rultor merge

[rultor]

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@victornoel Done! FYI, the full log is here (took me 10min)

[0crat]

Code review was too long (53 days), architects (@victornoel) were penalized, see §55

[0crat]

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@0crat quality good