yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1538) - replace the constructor to use an iterable #1596

Closed SergiusAC closed 3 years ago

SergiusAC commented 3 years ago

The PR is related to #1538, but also has solution for #1537, because they are interconnected.

victornoel commented 3 years ago

@SergiusAC could you remove the keyword "resolves" from the description? If you leave it, github will auto close the issue when this PR will be merged and we are relying on 0pdd or bug submitter for closing tickets :)

A REV will soon be assigned by 0crat to your PR by the way, sometimes he is a bit slow to react ;)

SergiusAC commented 3 years ago

@victornoel Thanks, I edited the description.

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

SergiusAC commented 3 years ago

@victornoel My PR was approved by @andreoss

victornoel commented 3 years ago

@SergiusAC thx

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 11min)

0crat commented 3 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 3 years ago

@andreoss please make sure you will find at least 3 issues during next CR, thanks

sereshqua commented 3 years ago

@0crat quality acceptable