yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1567) Generify `org.cactoos.proc` package #1608

Closed DmitryBarskov closed 3 years ago

DmitryBarskov commented 3 years ago

For #1567:

Generify incoming parameters (use ? super T) for next classes:

victornoel commented 3 years ago

@andreoss the fact we are going package by package is because in the past we created one todo per package. All in all, I think it's not so bad, at least it makes it easier to review (apparently not enough because it took the two of us to detect flaws in this PR ^^) since we have to check the whole class during review, not only the changes themselves :)

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

0crat commented 3 years ago

@andreoss/z resigned from #1608, since the job is not in scope anymore