yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

Use proper generics in `ForEach` #1610

Closed andreoss closed 3 years ago

andreoss commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #1610 (96cc063) into master (c0c5874) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1610      +/-   ##
============================================
+ Coverage     90.13%   90.14%   +0.01%     
- Complexity     1613     1615       +2     
============================================
  Files           302      302              
  Lines          3780     3784       +4     
  Branches        121      121              
============================================
+ Hits           3407     3411       +4     
  Misses          339      339              
  Partials         34       34              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/proc/ForEach.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/main/java/org/cactoos/proc/BiProcOf.java 100.00% <0.00%> (ø) 9.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0c5874...96cc063. Read the comment docs.

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 3 years ago

@0crat in

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1610; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

victornoel commented 3 years ago

@andreoss see my latest comment: the objective is to have tests that will ensure us the generic variance is working as expected when writing normal Java relying on the inference from the compiler for generics.

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1610; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1610; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 3 years ago

@victornoel/z everybody who has role REV is banned at #1610; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32: