yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1565) Improve generic variance for `org.cactoos.iterator` #1612

Closed DmitryBarskov closed 3 years ago

DmitryBarskov commented 3 years ago

For #1565:

Please also see #1611.

Add covariant constructor params for

Generify RangeOf(T, T, Func<T, T>)

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 3 years ago

@0crat in

codecov-commenter commented 3 years ago

Codecov Report

Merging #1612 (a301bce) into master (510666e) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1612      +/-   ##
============================================
- Coverage     90.08%   90.07%   -0.01%     
+ Complexity     1603     1602       -1     
============================================
  Files           298      298              
  Lines          3750     3748       -2     
  Branches        122      122              
============================================
- Hits           3378     3376       -2     
  Misses          338      338              
  Partials         34       34              
Impacted Files Coverage Δ
src/main/java/org/cactoos/iterator/Cycled.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/iterator/Endless.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/iterator/Immutable.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/iterator/RangeOf.java 81.81% <100.00%> (ø)
src/main/java/org/cactoos/iterator/Repeated.java 81.81% <100.00%> (-2.80%) :arrow_down:
src/main/java/org/cactoos/iterator/Reversed.java 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 510666e...a301bce. Read the comment docs.

victornoel commented 3 years ago

@DmitryBarskov I think the best to have the whole CI passing would be to simply increase test coverage independently of what was changed in this PR. You can also safely ignore the error since it's "just" -0.01%" :)

victornoel commented 3 years ago

@DmitryBarskov did you validate that along with the changes done in #1611 there are no more need for change sin the iterator package?

DmitryBarskov commented 3 years ago

@DmitryBarskov did you validate that along with the changes done in #1611 there are no more need for change sin the iterator package?

@victornoel yes, no changes needed (related to the ticket)

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

0crat commented 3 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 3 years ago

@andreoss please make sure you will find at least 3 issues during next CR, thanks

sereshqua commented 3 years ago

@0crat quality acceptable