yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

Use `Fallback` instead of `Func` #1615

Closed andreoss closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #1615 (08c55a7) into master (6b71044) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1615      +/-   ##
============================================
+ Coverage     90.07%   90.09%   +0.01%     
+ Complexity     1602     1601       -1     
============================================
  Files           298      298              
  Lines          3748     3745       -3     
  Branches        122      122              
============================================
- Hits           3376     3374       -2     
+ Misses          338      337       -1     
  Partials         34       34              
Impacted Files Coverage Δ
src/main/java/org/cactoos/Fallback.java 100.00% <100.00%> (ø)
...rc/main/java/org/cactoos/bytes/UncheckedBytes.java 100.00% <100.00%> (+8.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b71044...08c55a7. Read the comment docs.

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 3 years ago

@andreoss I was surprised when I saw that UncheckedBytes, contrary to many of the other UncheckedXXX classes this fallback paramter... I'm not convinced there is a real use for this. I would instead propose to remove this parameter at all, here and in the other UncheckedXXX classes. Along with this, we can think about introducing and unifying how all the XXXWithFallback work.

WDYT? If you like the idea and create a ticket for it, I will put it in scope

victornoel commented 3 years ago

@andreoss one of the tests if failing apparently

andreoss commented 3 years ago

@victornoel A flaky test, apparently.

victornoel commented 3 years ago

@andreoss yep… let's just ignore it ^^

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 11min)

0crat commented 3 years ago

Job gh:yegor256/cactoos#1615 is not assigned, can't get performer

0pdd commented 3 years ago

@andreoss the puzzle #1623 is still not solved.

victornoel commented 3 years ago

@0crat status

0pdd commented 2 years ago

@andreoss the puzzle [#unknown]() is still not solved.

0crat commented 2 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32: