Closed DmitryBarskov closed 3 years ago
Merging #1620 (85a26bd) into master (cc5daf0) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1620 +/- ##
============================================
+ Coverage 90.07% 90.10% +0.02%
- Complexity 1602 1603 +1
============================================
Files 298 298
Lines 3748 3748
Branches 122 122
============================================
+ Hits 3376 3377 +1
Misses 338 338
+ Partials 34 33 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/main/java/org/cactoos/text/Abbreviated.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/Flattened.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/FormattedText.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/Joined.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/Mapped.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/Strict.java | 100.00% <ø> (ø) |
|
src/main/java/org/cactoos/text/Sub.java | 86.20% <ø> (ø) |
|
src/main/java/org/cactoos/text/Replaced.java | 100.00% <100.00%> (ø) |
|
src/main/java/org/cactoos/scalar/Solid.java | 100.00% <0.00%> (+10.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cc5daf0...85a26bd. Read the comment docs.
@DmitryBarskov so one last check: did you validate that there were no more generic to update in the whole text package?
@victornoel found some other parameters for generalizing. But I skipped some params when they are regular expressions. I think they should be string literals. WDYT?
@DmitryBarskov sorry, I'm missing a bit of context: which one are you talking about that should be String
instead of CharSequence
?
@victornoel I'm talking about ctor Split(final Text text, final String rgx, final int lmt)
. Do you think CharSequence
is used for regular expressions?
@DmitryBarskov I think it's not the responsibility of Split
to know how its input are built, so yes, if we decide that the interface to use for string (not the java type, the concept) is CharSequence
, then it should be used everywhere.
@DmitryBarskov sorry for the late feedback, I didn't realize you made some changes :) don't hesitate to ping me if you don't get any updates in the future!
@rultor merge
@rultor merge
@victornoel OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@victornoel Done! FYI, the full log is here (took me 9min)
@0crat status
@0crat status
@0crat status (here)
@victornoel This is what I know about this job in C63314D6Z, as in §32:
REV
@0crat out
Code review was too long (78 days), architects (@victornoel) were penalized, see §55
@0crat quality good
For #1574:
CharSequence
instead ofString
when possibleFlattened
Collection
if type parameter doesn't matterFunc