yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1568) Generify org.cactoos.iterable package #1621

Closed DmitryBarskov closed 2 years ago

DmitryBarskov commented 3 years ago

For #1568.

Generify parameter types in constructors of org.cactoos.iterable package classses:

codecov-commenter commented 3 years ago

Codecov Report

Merging #1621 (16671bd) into master (cc5daf0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1621   +/-   ##
=========================================
  Coverage     90.07%   90.07%           
  Complexity     1602     1602           
=========================================
  Files           298      298           
  Lines          3748     3748           
  Branches        122      122           
=========================================
  Hits           3376     3376           
  Misses          338      338           
  Partials         34       34           
Impacted Files Coverage Δ
src/main/java/org/cactoos/iterable/Joined.java 100.00% <ø> (ø)
...rc/main/java/org/cactoos/iterable/Partitioned.java 100.00% <ø> (ø)
src/main/java/org/cactoos/iterable/RangeOf.java 100.00% <ø> (ø)
src/main/java/org/cactoos/iterable/Repeated.java 100.00% <ø> (ø)
src/main/java/org/cactoos/iterable/Shuffled.java 75.00% <ø> (ø)
src/main/java/org/cactoos/iterable/Skipped.java 100.00% <ø> (ø)
src/main/java/org/cactoos/iterable/Sliced.java 100.00% <ø> (ø)
src/main/java/org/cactoos/iterable/IterableOf.java 95.83% <100.00%> (ø)
src/main/java/org/cactoos/iterable/NoNulls.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc5daf0...16671bd. Read the comment docs.

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 3 years ago

@0crat in

victornoel commented 2 years ago

@0crat in

victornoel commented 2 years ago

@0crat in

victornoel commented 2 years ago

@DmitryBarskov can't make 0crat manage this. So I reviewed it and it's all good. I just need a last check: did you verify if that was all the classes left in iterable package for this todo?

DmitryBarskov commented 2 years ago

@victornoel yes, I did.

victornoel commented 2 years ago

@DmitryBarskov great, thx!

victornoel commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)