search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
737 stars 163 forks source link

(#1575) Generify `org.cactoos.collection` package #1624

Closed rocket-3 closed 2 years ago

rocket-3 commented 3 years ago

For #1575.

Generify parameter types in constructors of org.cactoos.collection package classses:

It's done by using unchecked casts, because there are absolutely no other ways to achive this, due to JDK interfaces limitations.

victornoel commented 2 years ago

@rocket-3 nice use of @implNote, I didn't know about this!

codecov-commenter commented 2 years ago

Codecov Report

Merging #1624 (31eb51a) into master (445cf16) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1624      +/-   ##
============================================
- Coverage     90.12%   90.10%   -0.02%     
- Complexity     1602     1603       +1     
============================================
  Files           298      298              
  Lines          3745     3749       +4     
  Branches        122      122              
============================================
+ Hits           3375     3378       +3     
  Misses          337      337              
- Partials         33       34       +1
Impacted Files Coverage Δ
src/main/java/org/cactoos/collection/NoNulls.java 100.00% <ø> (ø)
...rc/main/java/org/cactoos/collection/Immutable.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) :arrow_down:
src/main/java/org/cactoos/map/MapOf.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445cf16...31eb51a. Read the comment docs.

victornoel commented 2 years ago

@rocket-3 the linters CI job failed, it must be fixed before we can merge this PR :)

rocket-3 commented 2 years ago

@rocket-3 nice use of @implNote, I didn't know about this!

Also because of that linters CI job failed...

victornoel commented 2 years ago

@rultor merge

victornoel commented 2 years ago

@rocket-3 thx

rultor commented 2 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 13min)