yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons

https://www.cactoos.org

MIT License

737 stars 163 forks source link

(#1618) MapOf(map, X, Y) and MapOf(X, Y) new ctors #1625

Closed evpl closed 3 years ago

evpl commented 3 years ago

For issue #1618

Added new constructors:

MapOf(map, X, Y)
MapOf(X, Y)

And tests

evpl commented 3 years ago

@victornoel hi, I fixed the javadoc.

victornoel commented 3 years ago

@evpl perfect :)

codecov-commenter commented 3 years ago

Codecov Report

Merging #1625 (4968768) into master (445cf16) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1625      +/-   ##
============================================
+ Coverage     90.12%   90.13%   +0.01%     
- Complexity     1602     1604       +2     
============================================
  Files           298      298              
  Lines          3745     3749       +4     
  Branches        122      122              
============================================
+ Hits           3375     3379       +4     
  Misses          337      337              
  Partials         33       33

Impacted Files	Coverage Δ
src/main/java/org/cactoos/map/MapOf.java	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445cf16...4968768. Read the comment docs.

victornoel commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 11min)

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

The job #1625 is in scope for 3days
The role is REV
The job is assigned to @andreoss/z for 3days
There is no monetary reward attached, it's a free job
The job doesn't have any impediments
The budget is 15 minutes/points
These users are banned and won't be assigned:
- @evpl/z: This user reported the ticket
Job footprint (restricted area)

victornoel commented 3 years ago

@0crat out

victornoel commented 3 years ago

@0crat out

victornoel commented 3 years ago

@0crat status

0crat commented 3 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

The job #1625 is in scope for 3days
The role is REV
The job is assigned to @andreoss/z for 3days
There is no monetary reward attached, it's a free job
The job doesn't have any impediments
The budget is 15 minutes/points
These users are banned and won't be assigned:
- @evpl/z: This user reported the ticket
Job footprint (restricted area)

0crat commented 3 years ago

@0crat out (here)

@victornoel Job #1625 is not in the agenda of @andreoss/z, can't set title

0crat commented 3 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 3 years ago

@0crat out (here)

@victornoel Job #1625 is not in the agenda of @andreoss/z, can't set title

sereshqua commented 3 years ago

@0crat quality bad

0crat commented 3 years ago

Quality is low, no payment, see §31