yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
735 stars 164 forks source link

(#1573) Generify `org.cactoos.experimental` package. #1627

Closed rocket-3 closed 2 years ago

rocket-3 commented 2 years ago

For #1573.

Actually one class and one constructor, which contract, in my opinion, could be relaxed.

rocket-3 commented 2 years ago

@0crat status

rocket-3 commented 2 years ago

@0crat, status

0crat commented 2 years ago

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

victornoel commented 2 years ago

@0crat status

codecov-commenter commented 2 years ago

Codecov Report

Merging #1627 (a14ab90) into master (445cf16) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1627      +/-   ##
============================================
- Coverage     90.12%   90.10%   -0.02%     
- Complexity     1602     1603       +1     
============================================
  Files           298      298              
  Lines          3745     3749       +4     
  Branches        122      122              
============================================
+ Hits           3375     3378       +3     
  Misses          337      337              
- Partials         33       34       +1     
Impacted Files Coverage Δ
...rc/main/java/org/cactoos/experimental/Threads.java 100.00% <ø> (ø)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) :arrow_down:
src/main/java/org/cactoos/map/MapOf.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445cf16...a14ab90. Read the comment docs.

rocket-3 commented 2 years ago

@victornoel, how can I fix that failed code coverage check?

victornoel commented 2 years ago

@rocket-3 no need to, it's more of a glitch than an actual problem, minus 0.02% is the same as no changes. I never found how to prevent this unfortunately...

victornoel commented 2 years ago

@0crat status

0crat commented 2 years ago

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

victornoel commented 2 years ago

@0crat in

rocket-3 commented 2 years ago

@0crat status

victornoel commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)