yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
735 stars 164 forks source link

(#1569) Generify part of `org.cactoos.scalar` package #1628

Closed rocket-3 closed 2 years ago

rocket-3 commented 2 years ago

For #1569.

Relaxed parameter types by adding wildcards in constructors of classes of org.cactoos.scalar package (first 9 classes in ABC order):

rocket-3 commented 2 years ago

@0crat status

rocket-3 commented 2 years ago

@0crat status

victornoel commented 2 years ago

@rocket-3 I'm a bit confused between this PR and #1626, are they solving the same todo? If yes, the process should be:

In both case your job is done, the issue is closed by 0pdd and you get the "points". Note that both your PRs seems to update the todo in a different way, this will create merge conflicts, so now that this is done, one of the PR should not touch it and the other should either delete it or update it if there is more work to do (on top of the two PRs).

0crat commented 2 years ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 2 years ago

Code review was too long (58 days), architects (@victornoel) were penalized, see §55

sereshqua commented 2 years ago

@0crat quality bad