search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
735 stars 164 forks source link

(#1566) Generify org.cactoos.list package #1635

Closed DmitryBarskov closed 2 years ago

DmitryBarskov commented 2 years ago

For #1566:

Generify some classes in org.cactoos.list package:

DmitryBarskov commented 2 years ago

Hey @victornoel! Could you have a look please?

codecov-commenter commented 2 years ago

Codecov Report

Merging #1635 (fb5fccb) into master (2d3d898) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1635      +/-   ##
============================================
+ Coverage     90.10%   90.13%   +0.02%     
- Complexity     1603     1604       +1     
============================================
  Files           298      298              
  Lines          3749     3749              
  Branches        122      122              
============================================
+ Hits           3378     3379       +1     
  Misses          337      337              
+ Partials         34       33       -1
Impacted Files Coverage Δ
src/main/java/org/cactoos/list/Joined.java 100.00% <ø> (ø)
src/main/java/org/cactoos/list/Immutable.java 100.00% <100.00%> (ø)
...n/java/org/cactoos/list/ImmutableListIterator.java 91.66% <100.00%> (ø)
...main/java/org/cactoos/list/JoinedListIterator.java 75.60% <100.00%> (ø)
src/main/java/org/cactoos/scalar/Solid.java 100.00% <0.00%> (+10.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d3d898...fb5fccb. Read the comment docs.

yegor256 commented 2 years ago

@victornoel what's up with this?

victornoel commented 2 years ago

@DmitryBarskov thank you. Did you verify that there was no more class in the list package that would need changes like those?

DmitryBarskov commented 2 years ago

@DmitryBarskov thank you. Did you verify that there was no more class in the list package that would need changes like those?

@victornoel yes, checked it twice

victornoel commented 2 years ago

@DmitryBarskov excellent, thank you very much!

victornoel commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)