yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
735 stars 164 forks source link

(#1564) Exploit generic variance of IO package #1647

Closed DmitryBarskov closed 1 year ago

DmitryBarskov commented 2 years ago

For #1564 "Exploit generic variance for package org.cactoos.io". Generify classes in org.cactoos.io package

Please note that there is more changes come regarding this issue.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1647 (72e5623) into master (e9125cd) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1647   +/-   ##
=========================================
  Coverage     90.10%   90.10%           
  Complexity     1612     1612           
=========================================
  Files           300      300           
  Lines          3779     3779           
  Branches        122      122           
=========================================
  Hits           3405     3405           
  Misses          340      340           
  Partials         34       34           
Impacted Files Coverage Δ
src/main/java/org/cactoos/io/OutputStreamTo.java 35.48% <ø> (ø)
src/main/java/org/cactoos/io/ReaderOf.java 96.55% <ø> (ø)
src/main/java/org/cactoos/func/IoCheckedFunc.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/io/CheckedInput.java 83.33% <100.00%> (ø)
src/main/java/org/cactoos/io/CheckedOutput.java 83.33% <100.00%> (ø)
...rc/main/java/org/cactoos/io/InputWithFallback.java 73.33% <100.00%> (ø)
src/main/java/org/cactoos/io/Joined.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/io/TempFolder.java 100.00% <100.00%> (ø)
src/main/java/org/cactoos/io/Zip.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

victornoel commented 2 years ago

@0crat assign @andreoss

victornoel commented 2 years ago

thx @andreoss for the review, I've thus assigned you :)

victornoel commented 1 year ago

@0crat assign @andreoss

victornoel commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@victornoel Done! FYI, the full log is here (took me 12min)

0crat commented 1 year ago

Code review was too long (106 days), architects (@victornoel) were penalized, see §55

0crat commented 1 year ago

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed