search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
735 stars 164 forks source link

Fixed examples in readme.md #1671

Closed advasileva closed 1 year ago

advasileva commented 1 year ago

According to issue #1670, I compiled and ran the code examples in README.md. Some of them didn't compile or crashed with an exception, so I fixed them

victornoel commented 1 year ago

@0crat assign me

advasileva commented 1 year ago

Should I update this PR somehow?

victornoel commented 1 year ago

@advasileva sorry I haven't had the time to review it yet, I will get back to you here when I do. I've assigned it to me because we don't have any dev nor reviewers available in the project unfortunately.

yegor256 commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

0crat commented 1 year ago

@victornoel/z resigned from #1671, since the job is not in scope anymore