search

yegor256 / cactoos

Object-Oriented Java primitives, as an alternative to Google Guava and Apache Commons
https://www.cactoos.org
MIT License
734 stars 162 forks source link

ThrowsOnFalse #1692

Closed h1alexbel closed 10 months ago

h1alexbel commented 10 months ago

closes #1175

h1alexbel commented 10 months ago

@yegor256 take a look, please

yegor256 commented 10 months ago

@victornoel what do you think?

h1alexbel commented 10 months ago

@victornoel fixed, check again, please

h1alexbel commented 10 months ago

@victornoel fixed, take a look again, please

victornoel commented 10 months ago

@h1alexbel looks good, thank you :)

victornoel commented 10 months ago

@rultor merge

rultor commented 10 months ago

@rultor merge

@h1alexbel @victornoel Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

victornoel commented 10 months ago

@yegor256 not sure why we have to codacy checks, but they make no sense with how we write tests, the error is:

JUnit tests should include assert() or fail()

How can we disable them?

yegor256 commented 10 months ago

@victornoel disabled. Once something new is pushed to this branch, CI checks will be re-run (without codacy)

victornoel commented 10 months ago

@h1alexbel please could you push again to this branch, for example squash all commits as one, it would be perfect.

h1alexbel commented 10 months ago

@victornoel sure, squashed, new pr is here: #1696

0crat commented 10 months ago

Job gh:yegor256/cactoos#1692 is not assigned, can't get performer