Closed tanmaysharma2001 closed 6 months ago
@tanmaysharma2001 looks like a very good start, thanks! Now, please, try to run make clean install
and then make test lint
, in order to check that the code doesn't break anything. Then, please, create a unit test for this script, similar to the tests we already have for other scripts.
Also, if it's a "step", we should name it like all other steps: XXX-name.sh
, where XXX
is a number.
Hi @yegor256 thanks a lot. I have fixed one the 1 test where my script was failing. Although, i had few problems with installing make clean install, which includes installing dependencies. I'm working on that. Meanwhile I request you to approve the PR so that it can run the tests again. Also i have written the unit test for the script too.
Also I wanted to ask about the step number. I didn't quite understand where should i name it cause other steps are named according to their purposes. For example: aggregate-join.sh.
Sorry if i misunderstood anything. Thanks.
@tanmaysharma2001 this should be a metric, not a "step". Put your file into the metrics/
directory and that's it.
Done @yegor256 Thanks a lot.
Fix for the Issue Number 24 in the Cam Repo.
Problem Description: For each .java class, let's count the number of other .java classes which it was updated together with, in the Git history.
Solution Description: