search

yegor256 / cam

Classes and Metriсs (CaM): a dataset of Java classes from public open-source GitHub repositories
http://cam.yegor256.com
MIT License
23 stars 32 forks source link

PEP 8: E501 line too long (129 > 120 characters) in ast.py #319

Open nikzor opened 3 months ago

nikzor commented 3 months ago

@yegor256 In ast.py file in repository we get warning from linter: "PEP 8: E501 line too long (129 > 120 characters)" in line 32 https://github.com/yegor256/cam/blob/428b12f04de249ff8f009c2199d9b947695dbf43/metrics/ast.py#L32 I suggest to fix it

nikzor commented 3 months ago

@yegor256 Please, check this PR #320

yegor256 commented 3 months ago

@nikzor but the build is clean. We don't see any warnings or errors. Before we fix this "bug", let's make sure we see it in the log, in CI pipeline. In other words, let's make our CI more strict.

nikzor commented 3 months ago

@yegor256 If you will agree, I can add new workflow with flake8 checker, that will check Python code and provide information about Python warnings

yegor256 commented 3 months ago

@nikzor yes, let's do it

nikzor commented 3 months ago

@yegor256 Is it better to do it in different issue?

nikzor commented 3 months ago

@yegor256 I believe that it makes no sense to consider problems related to the length of the string, since there are enough places in the repository code where we exceed 79 characters (this is the current value according to PEP8, without Pycharm overrides). However, this does not directly affect the quality of the code. However, flake8 provides an opportunity to check Python code in detail according to the writing convention, so adding this linter will help improve the repository in the future. The error E501 can be added to the exceptions, as it does not make much sense.