Closed timur-harin closed 3 months ago
@yegor256 I see from documentation that macOS runners do not support container job
Could I create a separate job for macOS to test sudo make install
?
@yegor256 I created another job for macos only, to check it we need to merge PR #337 and PR #339
@timur-harin maybe it's better to use matrix build? https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
@yegor256 As you see in this commit, I already tried, problem is in container job
@yegor256 I see from documentation that macOS runners do not support container job
Could I create a separate job for macOS to test
sudo make install
?
@yegor256 Please see again
@yegor256 Oh, yes! Now all is done!
In this separate job for macOS with make install
:
make install
without sudo
, because homebrew
should use without root
, if no
Error: Running Homebrew as root is extremely dangerous and no longer supported. As Homebrew does not drop privileges on installation you would be giving all build scripts full access to your system.
- in macOS JPEEK installed in `/opt/app/jpeek.jar`, so we need `sudo` to `mkdir` and `mv`
But this job takes a lot, will you manage to run this job only when you need?
To make this job works with current source code for `make test` - it will take a lot
@yegor256 please check
@timur-harin good work, thanks!
@yegor256 In this PR, I added:
macos-12
runnerLet's see if all will be fine, but because it will run container...