yegor256 / datum

Zerocracy Project Data Model
http://datum.zerocracy.com/
Other
33 stars 11 forks source link

Verbosity #322

Closed g4s8 closed 6 years ago

g4s8 commented 6 years ago

zerocracy/farm#535 - verbosity schema, xsl and tests

0crat commented 6 years ago

Job #322 is now in scope, role is REV

0crat commented 6 years ago

This pull request #322 is assigned to @carlosmiranda/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.

carlosmiranda commented 6 years ago

@yegor256 good to merge

yegor256 commented 6 years ago

@g4s8 I don't think we need commits. There are no commits in a job, only in a pull request, for example. Let's just count messages:

<verbosity>
  <order id="gh:test/test#1">13</order>
  <order id="gh:test/test#2">18</order>
</verbosity>

That's it.

g4s8 commented 6 years ago

@yegor256 fixed, please look again

yegor256 commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

0crat commented 6 years ago

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 6 years ago

The job #322 is now out of scope

0crat commented 6 years ago

Payment to ARC for a closed pull request, as in §28: +10 points just awarded to @yegor256/z

ypshenychka commented 6 years ago

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

No issues were found during code review. Please confirm that you'll try to find at least three problems while future reviews.

carlosmiranda commented 6 years ago

@ypshenychka yes, confirmed

ypshenychka commented 6 years ago

@carlosmiranda thanks

ypshenychka commented 6 years ago

@0crat quality acceptable

0crat commented 6 years ago

Order was finished, quality is "acceptable": +15 points just awarded to @carlosmiranda/z

0crat commented 6 years ago

Quality review completed: +8 points just awarded to @ypshenychka/z