Closed g4s8 closed 6 years ago
This pull request #322 is assigned to @carlosmiranda/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.
@yegor256 good to merge
@g4s8 I don't think we need commits
. There are no commits in a job, only in a pull request, for example. Let's just count messages:
<verbosity>
<order id="gh:test/test#1">13</order>
<order id="gh:test/test#2">18</order>
</verbosity>
That's it.
@yegor256 fixed, please look again
@rultor merge
@rultor merge
@yegor256 OK, I'll try to merge now. You can check the progress of the merge here
@carlosmiranda According to our QA Rules:
The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.
No issues were found during code review. Please confirm that you'll try to find at least three problems while future reviews.
@ypshenychka yes, confirmed
@carlosmiranda thanks
@0crat quality acceptable
zerocracy/farm#535 - verbosity schema, xsl and tests