For #339: assert-that template is not working correctly

[paulodamaso]

For #339:

• Added style attribute to code element in expected parameter in project.xsl;
• Replaced != operator by not(deep-equal()) in assertions.xsl because received parameters are document fragments, not strings;
• Added xmlns:xs so it can be excluded in assert-that comparisons (project.xsl puts xmlns:xs in its elements);
• Corrected actual and expected variable names in failure message.

[0crat]

Job #357 is now in scope, role is REV

[0crat]

This pull request #357 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

[paulodamaso]

@carlosmiranda Done! Thanks for the review.

[paulodamaso]

@g4s8 Travis is segfaulting, please take a look.

[g4s8]

@rultor merge

[rultor]

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@g4s8 @paulodamaso Oops, I failed. You can see the full log here (spent 5min)

7f0a1c48d000-7f0a1c490000 r-xp 00000000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f0a1c490000-7f0a1c68f000 ---p 00003000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f0a1c68f000-7f0a1c690000 r--p 00002000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f0a1c690000-7f0a1c691000 rw-p 00003000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f0a1c691000-7f0a1c693000 r-xp 00000000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f0a1c693000-7f0a1c892000 ---p 00002000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f0a1c892000-7f0a1c893000 r--p 00001000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f0a1c893000-7f0a1c894000 rw-p 00002000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f0a1c894000-7f0a1c999000 r-xp 00000000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f0a1c999000-7f0a1cb98000 ---p 00105000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f0a1cb98000-7f0a1cb99000 r--p 00104000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f0a1cb99000-7f0a1cb9a000 rw-p 00105000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f0a1cb9a000-7f0a1cba3000 r-xp 00000000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f0a1cba3000-7f0a1cda3000 ---p 00009000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f0a1cda3000-7f0a1cda4000 r--p 00009000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f0a1cda4000-7f0a1cda5000 rw-p 0000a000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f0a1cda5000-7f0a1cdd3000 rw-p 00000000 00:00 0 
7f0a1cdd3000-7f0a1cdd6000 r-xp 00000000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f0a1cdd6000-7f0a1cfd5000 ---p 00003000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f0a1cfd5000-7f0a1cfd6000 r--p 00002000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f0a1cfd6000-7f0a1cfd7000 rw-p 00003000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f0a1cfd7000-7f0a1cff0000 r-xp 00000000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f0a1cff0000-7f0a1d1ef000 ---p 00019000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f0a1d1ef000-7f0a1d1f0000 r--p 00018000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f0a1d1f0000-7f0a1d1f1000 rw-p 00019000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f0a1d1f1000-7f0a1d1f5000 rw-p 00000000 00:00 0 
7f0a1d1f5000-7f0a1d3b3000 r-xp 00000000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f0a1d3b3000-7f0a1d5b3000 ---p 001be000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f0a1d5b3000-7f0a1d5b7000 r--p 001be000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f0a1d5b7000-7f0a1d5b9000 rw-p 001c2000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f0a1d5b9000-7f0a1d5be000 rw-p 00000000 00:00 0 
7f0a1d5be000-7f0a1d89d000 r-xp 00000000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f0a1d89d000-7f0a1da9c000 ---p 002df000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f0a1da9c000-7f0a1daa2000 r--p 002de000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f0a1daa2000-7f0a1daa5000 rw-p 002e4000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f0a1daa5000-7f0a1dab7000 rw-p 00000000 00:00 0 
7f0a1dab7000-7f0a1dada000 r-xp 00000000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f0a1dba2000-7f0a1dbc5000 r--s 00000000 08:11 41812213                   /usr/local/rvm/rubies/ruby-2.3.3/bin/ruby
7f0a1dbc5000-7f0a1dbcc000 r--s 00000000 08:11 73274683                   /usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache
7f0a1dbcc000-7f0a1dcd1000 rw-p 00000000 00:00 0 
7f0a1dcd3000-7f0a1dcd4000 rw-p 00000000 00:00 0 
7f0a1dcd4000-7f0a1dcd5000 ---p 00000000 00:00 0 
7f0a1dcd5000-7f0a1dcd9000 rw-p 00000000 00:00 0 
7f0a1dcd9000-7f0a1dcda000 r--p 00022000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f0a1dcda000-7f0a1dcdb000 rw-p 00023000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f0a1dcdb000-7f0a1dcdc000 rw-p 00000000 00:00 0 
7fff7de2d000-7fff7e62c000 rw-p 00000000 00:00 0                          [stack]
7fff7e718000-7fff7e71a000 r--p 00000000 00:00 0                          [vvar]
7fff7e71a000-7fff7e71c000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]

[NOTE]
You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

/home/r/script.sh: line 9: 23025 Aborted                 (core dumped) rake
container 813152eb2254234a2c2226ee58bdaf8b0235653b1904fc5b75c4464bfee0e712 is dead
Fri Jun 29 15:04:30 CEST 2018

[paulodamaso]

@g4s8 Segfault again, please look.

[g4s8]

@rultor merge

[rultor]

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@g4s8 @paulodamaso Oops, I failed. You can see the full log here (spent 5min)

7f6c55b32000-7f6c55b35000 r-xp 00000000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f6c55b35000-7f6c55d34000 ---p 00003000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f6c55d34000-7f6c55d35000 r--p 00002000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f6c55d35000-7f6c55d36000 rw-p 00003000 08:11 41813130                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/trans/transdb.so
7f6c55d36000-7f6c55d38000 r-xp 00000000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f6c55d38000-7f6c55f37000 ---p 00002000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f6c55f37000-7f6c55f38000 r--p 00001000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f6c55f38000-7f6c55f39000 rw-p 00002000 08:11 41813087                   /usr/local/rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/x86_64-linux/enc/encdb.so
7f6c55f39000-7f6c5603e000 r-xp 00000000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f6c5603e000-7f6c5623d000 ---p 00105000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f6c5623d000-7f6c5623e000 r--p 00104000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f6c5623e000-7f6c5623f000 rw-p 00105000 08:11 73013394                   /lib/x86_64-linux-gnu/libm-2.19.so
7f6c5623f000-7f6c56248000 r-xp 00000000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f6c56248000-7f6c56448000 ---p 00009000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f6c56448000-7f6c56449000 r--p 00009000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f6c56449000-7f6c5644a000 rw-p 0000a000 08:11 73013366                   /lib/x86_64-linux-gnu/libcrypt-2.19.so
7f6c5644a000-7f6c56478000 rw-p 00000000 00:00 0 
7f6c56478000-7f6c5647b000 r-xp 00000000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f6c5647b000-7f6c5667a000 ---p 00003000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f6c5667a000-7f6c5667b000 r--p 00002000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f6c5667b000-7f6c5667c000 rw-p 00003000 08:11 73013372                   /lib/x86_64-linux-gnu/libdl-2.19.so
7f6c5667c000-7f6c56695000 r-xp 00000000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f6c56695000-7f6c56894000 ---p 00019000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f6c56894000-7f6c56895000 r--p 00018000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f6c56895000-7f6c56896000 rw-p 00019000 08:11 73013446                   /lib/x86_64-linux-gnu/libpthread-2.19.so
7f6c56896000-7f6c5689a000 rw-p 00000000 00:00 0 
7f6c5689a000-7f6c56a58000 r-xp 00000000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f6c56a58000-7f6c56c58000 ---p 001be000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f6c56c58000-7f6c56c5c000 r--p 001be000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f6c56c5c000-7f6c56c5e000 rw-p 001c2000 08:11 73013356                   /lib/x86_64-linux-gnu/libc-2.19.so
7f6c56c5e000-7f6c56c63000 rw-p 00000000 00:00 0 
7f6c56c63000-7f6c56f42000 r-xp 00000000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f6c56f42000-7f6c57141000 ---p 002df000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f6c57141000-7f6c57147000 r--p 002de000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f6c57147000-7f6c5714a000 rw-p 002e4000 08:11 41812250                   /usr/local/rvm/rubies/ruby-2.3.3/lib/libruby.so.2.3.0
7f6c5714a000-7f6c5715c000 rw-p 00000000 00:00 0 
7f6c5715c000-7f6c5717f000 r-xp 00000000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f6c57247000-7f6c5726a000 r--s 00000000 08:11 41812213                   /usr/local/rvm/rubies/ruby-2.3.3/bin/ruby
7f6c5726a000-7f6c57271000 r--s 00000000 08:11 73274683                   /usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache
7f6c57271000-7f6c57376000 rw-p 00000000 00:00 0 
7f6c57378000-7f6c57379000 rw-p 00000000 00:00 0 
7f6c57379000-7f6c5737a000 ---p 00000000 00:00 0 
7f6c5737a000-7f6c5737e000 rw-p 00000000 00:00 0 
7f6c5737e000-7f6c5737f000 r--p 00022000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f6c5737f000-7f6c57380000 rw-p 00023000 08:11 73013336                   /lib/x86_64-linux-gnu/ld-2.19.so
7f6c57380000-7f6c57381000 rw-p 00000000 00:00 0 
7fff7e595000-7fff7ed94000 rw-p 00000000 00:00 0                          [stack]
7fff7edc0000-7fff7edc2000 r--p 00000000 00:00 0                          [vvar]
7fff7edc2000-7fff7edc4000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]

[NOTE]
You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

/home/r/script.sh: line 9: 23025 Aborted                 (core dumped) rake
container 70631ae1170bcbb6f541232f33017cbf0e3f2c6b497c07e8856b8c5e53a76fa1 is dead
Fri Jun 29 20:04:15 CEST 2018

[g4s8]

@paulodamaso I just tried to merge #358 PR to ensure that rultor is working fine, looks like you have some breaking code in this branch.

[g4s8]

@paulodamaso looks like a bug in a native library (I suppose in "nokogiri"), can you reproduce same stacktrace? I'd try to downgrade "nokogiry" in Gemfile

[paulodamaso]

@g4s8 I've reproduced it in windows and linux; it happens only when I use deep-equal comparison. I'll try to downgrade nokogiri and see what happens.

[paulodamaso]

@g4s8 Stopped getting the error when downgrading nokogiri to version 1.8.0.

[g4s8]

@paulodamaso I downgraded nokogiri in master: #364, please merge it into this branch

[paulodamaso]

@g4s8 That did the trick, thanks.

[paulodamaso]

@carlosmiranda Please take a look, I think this is good now.

[g4s8]

@rultor merge

[rultor]

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 5min)

[0crat]

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #357 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

[ypshenychka]

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

Only one issue was found during code review. Please confirm that you'll try to find at least three major problems while future reviews.

[carlosmiranda]

@ypshenychka confirmed

[ypshenychka]

@carlosmiranda Thank you

[ypshenychka]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +15 point(s) just awarded to @carlosmiranda/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z