search

yegor256 / elegantobjects.github.io

Fan club for Elegant Objects programmers
https://www.elegantobjects.org
121 stars 66 forks source link

Add one user and one repo #50

Closed mgramin closed 6 years ago

0crat commented 6 years ago

@yegor256/z please, pay attention to this pull request

0crat commented 6 years ago

@mgramin/z this pull request is too small, just 3 lines changed (less than 10), there will be no formal code review; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

yegor256 commented 6 years ago

@mgramin what makes you think that sql-boot is designed in the spirit of EO? I tried to go through the source code and it's a pretty standard Java app, with getters, setters, annotations, mutability, etc.

mgramin commented 6 years ago

@yegor256 thanks for your questions.

I use getters/setters only to interact with third-party libraries (e.g. swagger and spring-boot magic) (In the future i plan to get rid of the spring boot).

All application are based on simple interfaces with simple implementations and many many decorators.

For example:

Interface - com.github.mgramin.sqlboot.model.resource_type.ResourceType

Its implementations:

Its decorators:

All these classes are pure immutability.

A more detailed analysis of my project was made in the @amihaiemil review for the Software Quality Award 2017 - https://gist.github.com/amihaiemil/239169ef959fc064307e06aef6d30fd4 (especially in paragraph 6)

yegor256 commented 6 years ago

@mgramin thanks!

0crat commented 6 years ago

The job is not in WBS, won't close the order