search

yegor256 / factbase

In-memory database of facts (records with attributes) with a predicative searching facility
https://rubygems.org/gems/factbase
MIT License
5 stars 3 forks source link

#98 tests for thread-safety #114

Closed Suban05 closed 2 months ago

Suban05 commented 2 months ago

Closes #98

Suban05 commented 2 months ago

@Yegorov @tank-bohr please review

Suban05 commented 2 months ago

@tank-bohr updated, please check

Suban05 commented 2 months ago

@tank-bohr fixed your comments and added puzzles to the failed tests

tank-bohr commented 2 months ago

@tank-bohr fixed your comments and added puzzles to the failed tests

@Suban05 What do puzzles mean? What do they do? Do they allow failed tests?

Suban05 commented 2 months ago

@tank-bohr see this comment https://github.com/yegor256/factbase/issues/98#issuecomment-2301288090

Suban05 commented 2 months ago

@yegor256 what do you think?

Suban05 commented 2 months ago

@yegor256 yes, updated

yegor256 commented 2 months ago

@Suban05 thanks!

0crat commented 2 months ago

@Yegorov Hello! Thank you for your code review contribution. Based on our team policy, you've earned 8 points for reviewing code. However, since there were fewer than 6 comments made during the review, we've had to deduct 10 points. Your final reward for this review is -2 points. Remember, more detailed feedback helps improve code quality. Your updated running balance is +455. Keep up the good work and aim for more comprehensive reviews next time! 👍

0crat commented 2 months ago

@tank-bohr Hey there, awesome job on the review! 🎉 You've snagged 14 points for this one: 8 for stepping up, and an extra 5 for those 11 thoughtful comments you left. Nice work on hitting that sweet spot – not too few, not too many comments. Your balance is now sitting pretty at +137. Keep up the great work, and remember, every review counts towards your bonus!

0crat commented 2 months ago

@Suban05 Great job on your contribution! 🎉 You've earned the maximum +32 points: +16 base, +16 for your 176 hits-of-code. Your code was concise enough to avoid deductions, and the review process was smooth. Keep up the excellent work and maintain this balance between quantity and quality. Your running balance is now +532. Looking forward to your next contribution!