Raise an error when there is a problem

sashee commented 5 years ago

Currently, if there is an error during the PlantUML generation process (either by missing the plantuml jar or error with the diagram) the site builds just fine but there will be an error image. This PR makes it fail-fast so that if there is an error the site won't build.

0crat commented 5 years ago

@yegor256/z please, pay attention to this pull request

0crat commented 5 years ago

@sashee/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

yegor256 commented 4 years ago

@rultor merge

rultor commented 4 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 4 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 2min)

yegor256 commented 4 years ago

@rultor release, tag is 1.3.4

yegor256 commented 4 years ago

@sashee thanks!

rultor commented 4 years ago

@rultor release, tag is 1.3.4

@yegor256 OK, I will release it now. Please check the progress here

rultor commented 4 years ago

@rultor release, tag is 1.3.4

@sashee @yegor256 Oops, I failed. You can see the full log here (spent 5min)


HEADS UP! i18n 1.1 changed fallbacks to exclude default locale.
But that may break your application.

Please check your Rails app for 'config.i18n.fallbacks = true'.
If you're using I18n (>= 1.1.0) and Rails (< 5.2.2), this should be
'config.i18n.fallbacks = [I18n.default_locale]'.
If not, fallbacks will be broken in your app by I18n 1.1.x.

For more info see:
https://github.com/svenfuchs/i18n/releases/tag/v1.1.0

\u001b[32mPost-install message from jekyll:\u001b[0m
-------------------------------------------------------------------------------------
Jekyll 4.0 comes with some major changes, notably:

  * Our `link` tag now comes with the `relative_url` filter incorporated into it.
    You should no longer prepend `{{ site.baseurl }}` to `{% link foo.md %}`
    For further details: https://github.com/jekyll/jekyll/pull/6727

  * Our `post_url` tag now comes with the `relative_url` filter incorporated into it.
    You shouldn't prepend `{{ site.baseurl }}` to `{% post_url 2019-03-27-hello %}`
    For further details: https://github.com/jekyll/jekyll/pull/7589

  * Support for deprecated configuration options has been removed. We will no longer
    output a warning and gracefully assign their values to the newer counterparts
    internally.
-------------------------------------------------------------------------------------
+ pdd -f /dev/null
Found 7 lines in /home/r/repo/.pdd
My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading .
Excluding target/**/*
Excluding src/main/resources/images/**/*
15 file(s) found, 171 excluded
Reading Rakefile...
Reading Gemfile...
Reading jekyll-plantuml.gemspec...
Reading .0pdd.yml...
Reading .github/ISSUE_TEMPLATE.md...
Reading .github/PULL_REQUEST_TEMPLATE.md...
Reading .travis.yml...
Reading LICENSE.txt...
Reading .pdd...
Reading .rultor.yml...
Reading lib/jekyll-plantuml.rb...
Reading lib/version.rb...
Reading README.md...
Reading .gitignore...
Reading Gemfile.lock...
+ bundle exec rake
\u001b[1mTraceback\u001b[m (most recent call last):
    4: from /home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'
    3: from /home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'
    2: from /usr/local/rvm/rubies/ruby-2.6.0/bin/rake:29:in `<main>'
    1: from /usr/local/rvm/rubies/ruby-2.6.0/lib/ruby/2.6.0/bundler/rubygems_integration.rb:482:in `block in replace_bin_path'
/usr/local/rvm/rubies/ruby-2.6.0/lib/ruby/2.6.0/bundler/rubygems_integration.rb:462:in `block in replace_bin_path': \u001b[1mcan't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (\u001b[1;4mGem::Exception\u001b[m\u001b[1m)\u001b[m
container 5cb4b51ebd35be486506bd2cceb81a0a66c7e63d465bd1b732626a5417770a5a is dead
Thu Oct 10 11:56:07 CEST 2019

yegor256 commented 4 years ago

@rultor release, tag is 1.3.4

rultor commented 4 years ago

@rultor release, tag is 1.3.4

@yegor256 OK, I will release it now. Please check the progress here

rultor commented 4 years ago

@rultor release, tag is 1.3.4

@yegor256 Done! FYI, the full log is here (took me 5min)

yegor256 commented 4 years ago

@sashee new version 1.3.4 is released

0crat commented 4 years ago

Job gh:yegor256/jekyll-plantuml#15 is not assigned, can't get performer

0crat commented 4 years ago

This job is not in scope

yegor256 / jekyll-plantuml

Raise an error when there is a problem #15