search

yegor256 / judges

Executor of Ruby scripts that update a Factbase both adding new and modifying facts inside it
https://rubygems.org/gems/judges
MIT License
2 stars 3 forks source link

embed CSS and JS assets into the HTML document #111

Open yegor256 opened 1 month ago

yegor256 commented 1 month ago

When we render HTML in print.rb, the final document has links to external resources, like CSS and JS. Would be more convenient to embed them right into the final HTML. This will make our HTML network-independent.

Also, we should embed SVG logo, as explained here.

PrateekPsingh commented 1 month ago

Assign this to me.

yegor256 commented 1 month ago

@PrateekPsingh thanks, please go ahead

yegor256 commented 1 month ago

@PrateekPsingh please, keep in mind that we must do the embedding in compile time. We should not copy the assets from where they are now and put in our our repository. Instead, we should download them on every rake run, place into assets directory, and then, when we print.rb, we put them into the HTML.