yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD
https://www.qulice.com
Other
301 stars 112 forks source link

justification for BranchContains usage #1187

Closed k3p7i3 closed 1 year ago

k3p7i3 commented 1 year ago

Closes: #1180

branchContains method was deprecated in checkstyle due to unexpected side-effects (too deep subtree scanning) and it's recommended to write your own traversal implementations for per need. BranchContains class is quite universal implementation for most needs, so i think it shouldn't be removed.

although, BranchContains class is only used in NonStaticMethodCheck for now and it's possible to move the BranchContains functionality to NonStaticMethodCheck's private method (we can discuss which way is better)

yegor256 commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)