yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD
https://www.qulice.com
Other
301 stars 112 forks source link

[#1198] update pmd to the latest #1210

Closed pnatashap closed 8 months ago

pnatashap commented 8 months ago
pnatashap commented 8 months ago

@yegor256 please take a look. this version does not produce NPE New rules that start failing (can be disabled): JUnitAssertionsShouldIncludeMessage - https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#junitassertionsshouldincludemessage UseShortArrayInitializer - https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#useshortarrayinitializer CloseResource - https://pmd.github.io/pmd/pmd_rules_java_errorprone.html#closeresource DoubleBraceInitialization - https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#doublebraceinitialization StringInstantiation - https://pmd.github.io/pmd/pmd_rules_java_performance.html#stringinstantiation ArrayIsStoredDirectly - https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#arrayisstoreddirectly ParameterAssignmentCheck (failed now on some existing lambdas) - https://checkstyle.sourceforge.io/checks/coding/parameterassignment.html

yegor256 commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@pnatashap @yegor256 Oops, I failed. You can see the full log here (spent 7min)

yegor256 commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@pnatashap @yegor256 Oops, I failed. You can see the full log here (spent 6min)

yegor256 commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@pnatashap @yegor256 Oops, I failed. You can see the full log here (spent 6min)

yegor256 commented 8 months ago

@pnatashap the problem is related to the formatting of XML documents. Try to install xcop locally and then do this:

xcop --fix --license=LICENSE.txt $(find . -name '*.xml')
pnatashap commented 8 months ago

@yegor256 please take a look

yegor256 commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

yegor256 commented 8 months ago

@pnatashap thanks!