yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD
https://www.qulice.com
Other
301 stars 112 forks source link

Visit package definitions in MultilineJavadocTagsCheck #1271

Closed MikailBag closed 6 months ago

MikailBag commented 6 months ago

Should fix #1072

pnatashap commented 6 months ago

@MikailBag it is good to have tests for the change to understand the reason for the change

MikailBag commented 6 months ago

@pnatashap I updated test so that it contains a PACKAGE_DEV token. Manual testing shows that it is emitted in package-info.java as well

$ cat package-info.java 
package foo.bar;
$ java -jar checkstyle-10.16.0-all.jar  -t package-info.java 
COMPILATION_UNIT -> COMPILATION_UNIT [1:0]
`--PACKAGE_DEF -> package [1:0]
    |--ANNOTATIONS -> ANNOTATIONS [1:11]
    |--DOT -> . [1:11]
    |   |--IDENT -> foo [1:8]
    |   `--IDENT -> bar [1:12]
    `--SEMI -> ; [1:15]
MikailBag commented 6 months ago

Thank you for comment, I've added a doc-comment to Valid.java.

pnatashap commented 6 months ago

@yegor256 please take a look

yegor256 commented 6 months ago

@rultor merge

rultor commented 6 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 months ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)