search

yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD
https://www.qulice.com
Other
301 stars 111 forks source link

enable per-file exclusion in CodeNarc module #148

Closed yegor256 closed 10 years ago

yegor256 commented 10 years ago

Let's enable per-file exclusion (similar to what we have in qulice-checkstyle and qulice-pmd) in qulice-codenarc module.

davvd commented 10 years ago

@longtimeago the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here

davvd commented 10 years ago

@longtimeago The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

longtimeago commented 10 years ago

@yegor256 CodeNarc require excludes to be defined as patterns, like *.groovy ... So it would be nice to specify excludes in pom the same way. This is the only solution I see, as CodeNarc validator don't provide callbacks to know file path and skip if it is excluded. So, are you OK with the fact that for CodeNarc excludes would looks different than for other validators?

longtimeago commented 10 years ago

Implementation (https://github.com/tpc2/qulice/pull/195)

longtimeago commented 10 years ago

@yegor256 Please, close the issue

yegor256 commented 10 years ago

thanks!

davvd commented 10 years ago

@longtimeago Much obliged! I've added 30 mins to your account in payment "37715692"