Check for jcabi-log logger to disallow String.format

[krzyk]

jcabi-log Logger supports formatting using standard %s, %d, etc., plus various extensions (http://log.jcabi.com/decors.html) so it is not needed to use String.format with it.

Create a check (you can look at InvalidSlf4jMessageFormat from pmd) that will fail a buld if jcabi-log Logger is provided with a String.format.

Invalid:

                final String message = String.format(                           
                    "Reducer does not exist: %s", reducer                       
                );                                                              
                Logger.error(this, message);                                    

Logger.info(this, String.format("Job %s deleted", job));

Valid:

Logger.info(this, "config exists for job: %s", id);

Logger.error(this, "#run(): %[exception]s", ex);

[krzyk]

@davvd valid bug

[davvd]

@davvd valid bug

@krzyk I just added bug tag here

[davvd]

@krzyk thank you for reporting this, I added 30 mins to your acc, transaction 95857375

[krzyk]

@davvd this is postponed

[davvd]

@davvd this is postponed

@krzyk OK, I put "postponed" label here

[davvd]

@davvd this is postponed

@krzyk right, I'll try to find someone else for this task