Improve PMD configuration

yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD

https://www.qulice.com

Other

299 stars 110 forks source link

Open mkordas opened 8 years ago

mkordas commented 8 years ago

Let's improve the ruleset.xml by:

remove exclusion of AvoidThreadGroup, they indeed should not be used
enable all reasonable rules from the following modules, these rules are missing without any reason:
- https://pmd.github.io/pmd-5.5.1/pmd-java/rules/index.html#Jakarta_Commons_Logging
- https://pmd.github.io/pmd-5.5.1/pmd-java/rules/index.html#Migration

krzyk commented 8 years ago

@mkordas OK, but, the ones on Comments look quite strange/unneeded:

mkordas commented 8 years ago

@krzyk right, I've removed Comments from description

krzyk commented 8 years ago

@davvd valid bug

krzyk commented 8 years ago

@davvd this is postponed

davvd commented 8 years ago

@davvd valid bug

@krzyk I tagged this as "bug"

davvd commented 8 years ago

@davvd this is postponed

@krzyk sure, thanks, I added "postponed" label to it

davvd commented 8 years ago

@davvd this is postponed

@krzyk I will ask somebody else to pick this up

davvd commented 8 years ago

@mkordas thanks for tis bug, I topped your account for 15 mins, transaction 57c5362106c056010bdd696f