original-brownbear commented 8 years ago

Background

At this point com.rultor.agents.docker.DockerExec only has one purpose, it periodically connects to the EC2 instance and by following functionality indicates whether the service is up and running or not. It's documented purpose Remove old images from Docker. is not fulfilled by it. The class was an attempt to resolve #906 . Eventually it turned out that the approach taken by the bash script that ships with this class com/rultor/agents/docker/rmi.sh caused certain issues described in #942 . So in 7c874cb7cd06360fcab58c8c23ecff4e27657676 the script was quickly turned into dead code by commenting the actual logic in it. Also the code at present is pretty much an 80% duplicate of it's successor DockerHealthCheck. => Fixing the doc on it to describe actual behaviour makes no sense anymore => this task.

Task Requires

remove DockerExec from the codebase
remove com/rultor/agents/docker/rmi.sh
ensure that this does not break the Service health display on the Rultor.com home page.
- See stacktrace in #1063 for details on how this class currently throws an exception and hence turns the service health display red.

original-brownbear commented 8 years ago

@alex-palevsky this is a bug.

original-brownbear commented 8 years ago

@alex-palevsky this depends on #1057.