yegor256 / rultor

DevOps team assistant that helps you merge, deploy, and release GitHub-hosted apps and libraries
https://www.rultor.com
Other
560 stars 156 forks source link

architect per command #806

Open yegor256 opened 9 years ago

yegor256 commented 9 years ago

architect option should work on a command level.

At the moment, there is only one way to define "architects" in the project:

architects:
  - yegor256
  - jeff

See how it's done here, for example: https://github.com/yegor256/rultor/blob/1.60.1/.rultor.yml#L13-L15

That's not enough. We should let it possible to define architects per commands:

deploy:
  architects:
    - yegor256
    - jeff

I believe, we just should use QnByArchitect a few more times here: https://github.com/yegor256/rultor/blob/1.60.1/src/main/java/com/rultor/agents/Agents.java#L291-L328 We need to use it not only for all commands, but also per each command, with specific XPath. The question here is how to test that it all works. I would suggest to move this static method Agents#commands() into its own class and create a unit test for it.

alex-palevsky commented 9 years ago

this task will get someone's attention soon

alex-palevsky commented 9 years ago

@yegor256 it is your task now,go ahead

alex-palevsky commented 9 years ago

@yegor256 many thanks for the report, I topped your account for 15 mins, transaction 000-1c7caeca

alex-palevsky commented 9 years ago

@yegor256 milestone set to 0.3 (correct me if I am wrong)

yegor256 commented 9 years ago

@alex-palevsky assign someone else pls

alex-palevsky commented 9 years ago

@alex-palevsky assign someone else pls

@yegor256 -30 points to your rating :(

alex-palevsky commented 9 years ago

@alex-palevsky assign someone else pls

@yegor256 no problem, I will try to find somebody else

dmzaytsev commented 9 years ago

@yegor256 sorry, I can't right now I don't know the details of the project, it will take too much time

alex-palevsky commented 8 years ago

@kujtimiihoxha it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket

The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

kujtimiihoxha commented 8 years ago

@yegor256 please give further information about the issue, also see #986

kujtimiihoxha commented 8 years ago

@alex-palevsky waiting for #986

alex-palevsky commented 8 years ago

@alex-palevsky waiting for #986

@kujtimiihoxha right, let's wait for #986

yegor256 commented 8 years ago

@kujtimiihoxha I updated the description of the ticket, let me know if that's enough

alex-palevsky commented 8 years ago

@yegor256 FYI, the issue we were waiting for (#986) is fixed

kujtimiihoxha commented 8 years ago

@alex-palevsky assign someone else

alex-palevsky commented 8 years ago

@alex-palevsky assign someone else

@kujtimiihoxha 30 points deducted from your rating

alex-palevsky commented 8 years ago

@alex-palevsky assign someone else

@kujtimiihoxha right, I'll try to find someone else for this task

original-brownbear commented 8 years ago

@alex-palevsky this is postponed.

alex-palevsky commented 8 years ago

@alex-palevsky this is postponed.

@original-brownbear thanks, I added "postponed" label

alex-palevsky commented 8 years ago

@alex-palevsky this is postponed.

@original-brownbear OK, I will try to assign someone else