search

yegor256 / takes

True Object-Oriented Java Web Framework without NULLs, Static Methods, Annotations, and Mutable Objects
https://www.takes.org
MIT License
805 stars 197 forks source link

added jakarta namespace #1309

Closed PeJetuz closed 1 month ago

PeJetuz commented 1 month ago

@yegor256 Hi! Please review, I also create PR for jcabi-parent. I'm not really clear on whether I should add a dependency to the parent or whether it should only be in takes. I also want to update the xml to the jakarta namespace. takes issue 1307

PeJetuz commented 1 month ago

@yegor256 I updated the XML to the Jakarta namespace. Please review. Thanks!

yegor256 commented 1 month ago

@PeJetuz maven doesn't build

PeJetuz commented 1 month ago

@yegor256 Sorry, it's mine failed. I should have tested the build on jdk 11. The artifact "jakarta.ws.rs:jakarta.ws.rs-api:4.0.0" is not compatible with JDK 11, only with 17 and later. Jakarta EE 11: This specification requires that containers support execution in a Java™ runtime environment, as defined by the Java Platform, Standard Edition specification, v17 or later (Java SE 17 or later). I rolled back the version of this artifact to 3.1.0. Should I also create a new PR for jcabi-parent to downgrade this artifact?

PeJetuz commented 1 month ago

@yegor256 Is it possible to run the build again? Thanks!

yegor256 commented 1 month ago

@rultor merge

rultor commented 1 month ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 month ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

yegor256 commented 1 month ago

@PeJetuz thanks!