RsGzip incorrectly compresses binary data

[yegor256]

There is a bug in RsGzip, it fails to compress binary data that contains 0x00 bytes. This looks like a typo, let's reproduce it and fix.

[yegor256]

@rultor release, tag is 0.10.1

[davvd]

@yegor256 the task is yours (budget is 30 mins)

[davvd]

@yegor256 thank you for the ticket reported, I topped your account for 15 mins, transaction 000-f45336be

[yegor256]

@rultor release, tag is 0.10.1

[rultor]

@rultor release, tag is 0.10.1

@yegor256 OK, I will release it now. Please check the progress here

[rultor]

Release 0.10.1 already exists! I can't duplicate it, but I posted a comment there. In the future, try to avoid duplicate releases

[rultor]

@rultor release, tag is 0.10.1

@yegor256 Done! FYI, the full log is here (took me 20min)

[rultor]

@rultor release, tag is 0.10.1

@yegor256 OK, I will release it now. Please check the progress here

[rultor]

@rultor release, tag is 0.10.1

@yegor256 Oops, I failed. You can see the full log here (spent 6min)

+ set -e
+ set -o pipefail
++ dirname /tmp/rultor-EBcL/run.sh
+ cd /tmp/rultor-EBcL
+ echo 32282
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Mon Mar 30 23:11:13 CEST 2015
+ uptime
 23:11:13 up 43 days, 42 min,  0 users,  load average: 9.02, 10.29, 9.15
+ head=git@github.com:yegor256/takes.git
+ head_branch=master
+ tag=0.10.1
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:yegor256/takes.git' '--env=head_branch=master' '--env=tag=0.10.1')
+ image=yegor256/rultor
+ squash=false
+ directory=
+ scripts=('sudo locale-gen en_US en_US.UTF-8' ';' 'sudo dpkg-reconfigure locales' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'sudo gem install pdd' ';' 'mvn versions:set "-DnewVersion=${tag}"' ';' 'git commit -am "${tag}"' ';' 'mvn clean deploy -Ptakes -Psonatype --errors --settings ../settings.xml' ';' 'mvn clean site-deploy -Ptakes -Psite --errors --settings ../settings.xml' ';')
+ container=yegor256_takes_96
+ as_root=false
+ git clone --branch=master --depth=10 git@github.com:yegor256/takes.git repo
Initialized empty Git repository in /tmp/rultor-EBcL/repo/.git/
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'sudo locale-gen en_US en_US.UTF-8' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo locale-gen en_US en_US.UTF-8' ';' 'sudo dpkg-reconfigure locales' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'sudo gem install pdd' ';' 'mvn versions:set "-DnewVersion=${tag}"' ';' 'git commit -am "${tag}"' ';' 'mvn clean deploy -Ptakes -Psonatype --errors --settings ../settings.xml' ';' 'mvn clean site-deploy -Ptakes -Psite --errors --settings ../settings.xml' ';'
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
Version: SKS 1.1.5
gpg: armor header: 
Comment: Hostname: keys.exosphere.de
gpg: armor header: 
gpg: pub  2048R/9AF0FA4C 2014-08-17  Rultor.com <gpg@rultor.com>
gpg: key 9AF0FA4C: "Rultor.com <gpg@rultor.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1
++ pwd
++ pwd
+ gpg --verbose --keyring=/tmp/rultor-EBcL/.gpg/pubring.gpg --secret-keyring=/tmp/rultor-EBcL/.gpg/secring.gpg --decrypt repo/curl-appveyor.cfg.asc
Version: GnuPG v1
gpg: armor header: 
gpg: public key is 9A839C3A
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: encrypted with 2048-bit RSA key, ID 9A839C3A, created 2014-08-17
      "Rultor.com <gpg@rultor.com>"
gpg: AES256 encrypted data
gpg: original file name='curl-appveyor.cfg.enc'
+ gpg --no-tty --batch --verbose --decrypt --passphrase rultor-key:yegor256/takes curl-appveyor.cfg.enc
Version: GnuPG v1
gpg: armor header: 
gpg: CAST5 encrypted data
gpg: encrypted with 1 passphrase
gpg: original file name='curl-appveyor.cfg'
gpg: WARNING: message was not integrity protected
+ rm -rf curl-appveyor.cfg.enc
+ rm -rf .gpg
+ '[' -z 0.10.1 ']'
+ cd repo
++ git tag -l 0.10.1
+ '[' 0.10.1 ']'
+ echo 'Tag 0.10.1 already exists!'
Tag 0.10.1 already exists!
+ exit -1

[davvd]

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

[elenavolokhova]

@yegor256 According to our quality rules:

Problem reporter and problem solver are two different persons.

This was not a case in this ticket. Please, try to avoid such situation in future.

Ticket title and description clearly state what is broken and what kind of fix is expected

There is no description provided. Please, update it for future reference.

[yegor256]

@elenavolokhova description updated. You're right about the "same person" problem, I'll try to avoid that in the future

[elenavolokhova]

@yegor256 Thank you!

[elenavolokhova]

@davvd Ticket passed QA review. Quality is acceptable.

[davvd]

@davvd Ticket passed QA review. Quality is acceptable.

@elenavolokhova thank you

[davvd]

@yegor256 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 54661728; Thanks so much! Your account was topped up for 1 hour (transaction ID is 000-4379c4ea, the task took 13 hours and 3 mins); age=5, that's why a bonus here for fast delivery; +60 added to your rating, current score is: +8598