Removing all pending notifications

[peter-lyons-kehl]

After adding a new pipe at www.wring.io, it seems to clear all pending notifications. That is not mentioned at https://www.wring.io/pipes nor at http://www.yegor256.com/2016/03/15/wring-dispatcher-github-notifications.html. Very user unfriendly.

I set up a pipe that I expected only to remove notifications matching ignore value. But all notifications disappeared.

{
  "class": "io.wring.agents.github.AgGithub",
  "token": "my-token",
  "ignore": "SeleniumHQ/selenium-ide"
}

Either document it, or better: make it not remove any pending notifications (meaning: Only apply the pipe to any new notifications since the pipeline creation).

[0crat]

@carlosmiranda/z please, pay attention to this issue

[0crat]

@peter-kehl/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

[carlosmiranda]

@0crat in

[0crat]

@0crat in (here)

@carlosmiranda Job #65 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @peter-kehl/z

[0crat]

@carlosmiranda/z everybody who has role DEV is banned at #65; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@carlosmiranda/z everybody who has role DEV is banned at #65; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@carlosmiranda/z everybody who has role DEV is banned at #65; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

The job #65 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[paulodamaso]

@peter-kehl @carlosmiranda What about setting an date for IgnoreEvents and make it just work on events after this date?

[carlosmiranda]

@paulodamaso my understanding is @peter-kehl wants to NOT clear notifications that were pending before setting up the pipe. What's happening is it's only processing notifs created after the new pipe, with the pending ones getting lost.

There might be a Github API limitation that's causing this, I'm not sure at the moment. Whatever the case let's either fix it or document the limitation.

[peter-lyons-kehl]

Hi @carlosmiranda and @paulodamaso ,

Confirming Carlos' understanding: NOT to clear notifications that were pending before setting up the pipe, or to document the fact.

[carlosmiranda]

@peter-kehl thanks for the clarification, I modified my comment a bit.

P.S. can you edit your comment so that you tag us with our Github names? Just a minor point about our project policy.

[paulodamaso]

@carlosmiranda @peter-kehl What I've found so far: Github Agent AgGithub clears all notifications from Github after pushing them to database; it calls https://developer.github.com/v3/activity/notifications/#mark-notifications-as-read-in-a-repository , efectivelly marking all older notifications as read. What we could do is to use https://developer.github.com/v3/activity/notifications/#list-your-notifications to iterate notifications manually (ignoring notifications before the pipe creation) and then iterate them manually and mark it as read with https://developer.github.com/v3/activity/notifications/#mark-as-read endpoint . This solves the problem, I think.

[peter-lyons-kehl]

@carlosmiranda and @paulodamaso, up to you to discuss/choose whether to have the change (how big could it be?), or to document the current behavior.

[carlosmiranda]

@paulodamaso sounds like a viable way to fix it, lets do it.

[paulodamaso]

@carlosmiranda I misunderstood the docs. We can't set notifications read one by one using the API, so I'm afraid that's impossible to do what @peter-kehl wants. I've added a line explaining this.

[paulodamaso]

@peter-kehl Merged, please close.

[paulodamaso]

@0crat status

[0crat]

@0crat status (here)

@paulodamaso This is what I know about this job in C7FCB1EQN, as in §32:

• The job #65 is in scope for 16days
• The role is DEV
• The job is assigned to @paulodamaso/z for 5days
• There is a monetary reward attached
• @paulodamaso/z will get 50% of their hourly rate for this job
• The job doesn't have any impediments
• The budget is 30 minutes/points
• These users are banned and won't be assigned:
  • @peter-kehl/z: This user reported the ticket
• Job footprint (restricted area)

[paulodamaso]

@0crat out

[0crat]

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #65 is now out of scope

[0crat]

@0crat out (here)

@paulodamaso Job gh:yegor256/wring#65 is not assigned, can't get performer

[0crat]

@0crat out (here)

@paulodamaso The job is not in WBS, won't close the order

[ypshenychka]

@0crat quality good

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z