yegor256 / wring

Smart Inbox for GitHub Notifications
http://www.wring.io
Other
29 stars 4 forks source link

For #63: Fix of too many threads error. #68

Closed paulodamaso closed 6 years ago

paulodamaso commented 6 years ago

For #63: Fix of too many threads error.

0crat commented 6 years ago

Job #68 is now in scope, role is REV

0crat commented 6 years ago

@carlosmiranda/z everybody who has role DEV is banned at #68; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

carlosmiranda commented 6 years ago

@0crat assign @pinaf

0crat commented 6 years ago

@0crat assign @pinaf (here)

@carlosmiranda The job #68 assigned to @pinaf/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

0crat commented 6 years ago

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @carlosmiranda/z

g4s8 commented 6 years ago

@0crat status

0crat commented 6 years ago

@0crat status (here)

@g4s8 This is what I know about this job in C7FCB1EQN, as in §32:

pinaf commented 6 years ago

@carlosmiranda shouldn't the role here be REV?

paulodamaso commented 6 years ago

@pinaf Thanks for the review, please take a look.

pinaf commented 6 years ago

@carlosmiranda @paulodamaso Unfortunately I can't think of an easy way to tie this error down with a unit test, but it seems reasonable to infer that this abundance of threads would be related to instantiating executors services all the time, wouldn't you agree?

paulodamaso commented 6 years ago

@pinaf Fixed the last issue, please take a look. As for your question I've found difficult to unit test this error too. I think that the two conclusions are tied, this executor instantiating and the fixed check for 64 threads together were causing the issue, I think.

pinaf commented 6 years ago

@paulodamaso Looks good, thank you.

pinaf commented 6 years ago

@carlosmiranda Looks good to merge

carlosmiranda commented 6 years ago

@pinaf yeah, it's a bug, see https://github.com/zerocracy/farm/issues/1675

carlosmiranda commented 6 years ago

@0crat boost 1x

0crat commented 6 years ago

@0crat boost 1x (here)

@carlosmiranda Boost 1x was set for #68

0crat commented 6 years ago

Boosting tasks is against our principles, see §15: -10 point(s) just awarded to @carlosmiranda/z

carlosmiranda commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@carlosmiranda Done! FYI, the full log is here (took me 14min)

0crat commented 6 years ago

Job was finished in 18 hours, bonus for fast delivery is possible (see §36)

0crat commented 6 years ago

@ypshenychka/z please review this job completed by @pinaf/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 6 years ago

The job #68 is now out of scope

0crat commented 6 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @carlosmiranda/z

ypshenychka commented 6 years ago

@0crat quality good

0crat commented 6 years ago

Order was finished, quality is "good": +25 point(s) just awarded to @pinaf/z

0crat commented 6 years ago

Quality review completed: +8 point(s) just awarded to @ypshenychka/z