Closed paulodamaso closed 6 years ago
@0crat assign @pinaf
@0crat status
@0crat status (here)
@g4s8 This is what I know about this job in C7FCB1EQN, as in §32:
DEV
@carlosmiranda shouldn't the role here be REV
?
@pinaf Thanks for the review, please take a look.
@carlosmiranda @paulodamaso Unfortunately I can't think of an easy way to tie this error down with a unit test, but it seems reasonable to infer that this abundance of threads would be related to instantiating executors services all the time, wouldn't you agree?
@pinaf Fixed the last issue, please take a look. As for your question I've found difficult to unit test this error too. I think that the two conclusions are tied, this executor instantiating and the fixed check for 64 threads together were causing the issue, I think.
@paulodamaso Looks good, thank you.
@carlosmiranda Looks good to merge
@pinaf yeah, it's a bug, see https://github.com/zerocracy/farm/issues/1675
@0crat boost 1x
@rultor merge
@rultor merge
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@carlosmiranda Done! FYI, the full log is here (took me 14min)
Job was finished in 18 hours, bonus for fast delivery is possible (see §36)
@0crat quality good
For #63: Fix of too many threads error.
Executor
manage thread pool;