search

yegor256 / wring

Smart Inbox for GitHub Notifications
http://www.wring.io
Other
29 stars 4 forks source link

For #72: Introduce error mechanics. #75

Closed paulodamaso closed 6 years ago

paulodamaso commented 6 years ago

For #72: Introduce error mechanics:

0crat commented 6 years ago

Job #75 is now in scope, role is REV

0crat commented 6 years ago

This pull request #75 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

paulodamaso commented 6 years ago

@pinaf Made some changes, please take a look now.

pinaf commented 6 years ago

@paulodamaso thanks

pinaf commented 6 years ago

@carlosmiranda good to merge

carlosmiranda commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@carlosmiranda Done! FYI, the full log is here (took me 14min)

0crat commented 6 years ago

@ypshenychka/z please review this job completed by @pinaf/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 6 years ago

The job #75 is now out of scope

0crat commented 6 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @carlosmiranda/z

ypshenychka commented 6 years ago

@pinaf According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

Only two issues were found during code review. Please confirm that you'll try to find at least three major problems while future reviews.

pinaf commented 6 years ago

@ypshenychka I confirm.

ypshenychka commented 6 years ago

@pinaf thanks

ypshenychka commented 6 years ago

@0crat quality acceptable

ypshenychka commented 6 years ago

@0crat quality acceptable

0crat commented 6 years ago

@0crat quality acceptable (here)

@ypshenychka There is no quality review for #75, no performer

0crat commented 6 years ago

Order was finished, quality is "acceptable": +15 point(s) just awarded to @pinaf/z

0crat commented 6 years ago

Quality review completed: +8 point(s) just awarded to @ypshenychka/z