yegor256 / wring

Smart Inbox for GitHub Notifications
http://www.wring.io
Other
29 stars 4 forks source link

For #76: Exec register error tests. #79

Closed paulodamaso closed 6 years ago

paulodamaso commented 6 years ago

For #76:

0crat commented 6 years ago

Job #79 is now in scope, role is REV

0crat commented 6 years ago

This pull request #79 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

paulodamaso commented 6 years ago

@pinaf ping

paulodamaso commented 6 years ago

@pinaf Please take a look.

pinaf commented 6 years ago

@paulodamaso thanks @carlosmiranda good to merge

paulodamaso commented 6 years ago

@carlosmiranda ping

carlosmiranda commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@carlosmiranda @paulodamaso Oops, I failed. You can see the full log here (spent 8min)


Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-components/4.0/plexus-components-4.0.pom

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-components/4.0/plexus-components-4.0.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom

Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom

Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom

Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom

Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar

Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar

Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
Downloading: https://repo.maven.apache.org/maven2/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar (0 B at 0.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar (0 B at 0.0 KB/sec)

Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar (0 B at 0.0 KB/sec)

Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar (0 B at 0.0 KB/sec)
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 70 source files to /home/r/repo/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/r/repo/src/main/java/io/wring/model/Errors.java:[78,32] iterate() in io.wring.model.Errors.Simple cannot implement iterate() in io.wring.model.Errors
  overridden method does not throw java.io.IOException
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:11 min
[INFO] Finished at: 2018-10-30T21:51:18+00:00
[INFO] Final Memory: 68M/482M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:compile (default-compile) on project wring: Compilation failure
[ERROR] /home/r/repo/src/main/java/io/wring/model/Errors.java:[78,32] iterate() in io.wring.model.Errors.Simple cannot implement iterate() in io.wring.model.Errors
[ERROR] overridden method does not throw java.io.IOException
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 7cd511f399ce8dad1e7914932934202424a845c2487e34fe8f1edb628a325bbc is dead
Tue Oct 30 22:52:25 CET 2018
paulodamaso commented 6 years ago

@pinaf I think that it's good now

pinaf commented 6 years ago

@paulodamaso yep, thanks! @carlosmiranda let's try to merge again.

carlosmiranda commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@carlosmiranda Done! FYI, the full log is here (took me 14min)

0crat commented 6 years ago

@ypshenychka/z please review this job completed by @pinaf/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 6 years ago

The job #79 is now out of scope

0crat commented 6 years ago

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@4a62f1a2-e6e2-417c-9751-47fc0ca91c06, thread: AsyncProc-7
com.zerocracy.farm.reactive.StkRuntime[76] java.lang.IllegalStateException: org.codehaus.groovy.runtime.InvokerInvocationException in com.zerocracy.stk.pm.cost.funding.send_zold
org.codehaus.groovy.reflection.CachedMethod[105] org.codehaus.groovy.runtime.InvokerInvocationException: java.io.IOException: Zold payment failed, code=503
com.zerocracy.pmo.banks.Zold[83] java.io.IOException: Zold payment failed, code=503

0.37.5: CID: 947424ae-7e84-4d69-8404-d4fc2a40fbad, Type: "Send zold"

0crat commented 6 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @carlosmiranda/z

ypshenychka commented 6 years ago

@0crat quality good

0crat commented 6 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @pinaf/z

0crat commented 6 years ago

Quality review completed: +8 point(s) just awarded to @ypshenychka/z