Closed paulodamaso closed 6 years ago
This pull request #80 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
@pinaf ping
@pinaf Please take a look. I've decided to use FkError
for testing the page because implementing it to accept values would become too close to Error.Simple
implementation made in https://github.com/yegor256/wring/issues/76, and I don't want to duplicate this code.
@paulodamaso thanks, it looks good. @carlosmiranda good to merge.
@rultor merge
@rultor merge
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@carlosmiranda Done! FYI, the full log is here (took me 14min)
@pinaf According to our QA Rules:
The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.
Only two issues were found during code review. Please confirm that you'll try to find at least three major problems while future reviews.
@ypshenychka I confirm
@pinaf thanks
@0crat quality acceptable
For #77: