Closed paulodamaso closed 6 years ago
This pull request #81 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
@pinaf ping
@pinaf Corrections done, please take a look.
@paulodamaso thanks. a couple more.
@pinaf Done, please take a look now.
@paulodamaso thank you @carlosmiranda good to merge
@rultor merge
@rultor merge
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@carlosmiranda @paulodamaso Oops, I failed. You can see the full log here (spent 8min)
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-components/4.0/plexus-components-4.0.pom
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-components/4.0/plexus-components-4.0.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compilers/2.8.1/plexus-compilers-2.8.1.pom (0 B at 0.0 KB/sec)
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar
Downloading: https://repo.maven.apache.org/maven2/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar (0 B at 0.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/ow2/asm/asm/6.0_ALPHA/asm-6.0_ALPHA.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-api/2.8.1/plexus-compiler-api-2.8.1.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-manager/2.8.1/plexus-compiler-manager-2.8.1.jar (0 B at 0.0 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-compiler-javac/2.8.1/plexus-compiler-javac-2.8.1.jar (0 B at 0.0 KB/sec)
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 70 source files to /home/r/repo/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/r/repo/src/main/java/io/wring/fake/FkErrors.java:[68,28] iterate() in io.wring.fake.FkErrors cannot implement iterate() in io.wring.model.Errors
overridden method does not throw java.io.IOException
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:52 min
[INFO] Finished at: 2018-10-30T04:08:37+00:00
[INFO] Final Memory: 69M/524M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:compile (default-compile) on project wring: Compilation failure
[ERROR] /home/r/repo/src/main/java/io/wring/fake/FkErrors.java:[68,28] iterate() in io.wring.fake.FkErrors cannot implement iterate() in io.wring.model.Errors
[ERROR] overridden method does not throw java.io.IOException
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 57ee7ecf06c6a984a535705185a75cd30dc9e5f85f840d900bee312d09a5229f is dead
Tue Oct 30 05:08:51 CET 2018
@carlosmiranda Updated class, please try to merge again
@rultor merge
@rultor merge
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@carlosmiranda Done! FYI, the full log is here (took me 14min)
@0crat quality good
For #78:
DyError
andDyErrors
classeserrors
table on database