yegor256 / wring

Smart Inbox for GitHub Notifications
http://www.wring.io
Other
29 stars 4 forks source link

DyErrors.java:52-54: Add errors table to dynamo. This... #83

Closed 0pdd closed 5 years ago

0pdd commented 6 years ago

The puzzle 78-d3bf8dd1 from #78 has to be resolved:

https://github.com/yegor256/wring/blob/16c98ad38556a42ca9353c81f19a0e51ca8e4b2e/src/main/java/io/wring/dynamo/DyErrors.java#L52-L54

The puzzle was created by Paulo Lobo on 27-Oct-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be \"done\" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0crat commented 6 years ago

@carlosmiranda/z please, pay attention to this issue

0crat commented 6 years ago

Job #83 is now in scope, role is DEV

0crat commented 6 years ago

The job #83 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

paulodamaso commented 6 years ago

@carlosmiranda please take e look at this, I couldn't find where to put the script to create this table.

carlosmiranda commented 6 years ago

@yegor256 need your help here

paulodamaso commented 5 years ago

@yegor256 please take a look at this

paulodamaso commented 5 years ago

@0crat wait for @yegor256 response

0crat commented 5 years ago

@0crat wait for @yegor256 response (here)

@paulodamaso The impediment for #83 was registered successfully by @paulodamaso/z

yegor256 commented 5 years ago

@paulodamaso thanks!

0crat commented 5 years ago

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

The job #83 is now out of scope

ypshenychka commented 5 years ago

@paulodamaso According to our QA Rules:

Ticket must have references to all pull requests where the problem was actually fixed;

Please add reference to PR.

paulodamaso commented 5 years ago

@ypshenychka actually we were waiting for @yegor256 create the tables so I could remove the ignore annotation from the tests

ypshenychka commented 5 years ago

@paulodamaso So was it not possible to create PR for that?

paulodamaso commented 5 years ago

@yegor256 what's the status on this one? Have you created the table so I can make a PR for this one?

paulodamaso commented 5 years ago

@yegor256 ping

paulodamaso commented 5 years ago

@carlosmiranda Looks like something went wrong here, @yegor256 closed the issue but we do not know if he created the table that I need to uncomment and fix the tests

yegor256 commented 5 years ago

@paulodamaso what is the table I have to create? Give me the spec.

paulodamaso commented 5 years ago

@yegor256 These are the table specs:

{
    "AttributeDefinitions": [
        {
            "AttributeName": "urn",
            "AttributeType": "S"
        },
        {
            "AttributeName": "title",
            "AttributeType": "S"
        },
        {
            "AttributeName": "description",
            "AttributeType": "S"
        },
        {
            "AttributeName": "time",
            "AttributeType": "N"
        }
    ],
    "TableName": "errors"
}
ypshenychka commented 5 years ago

@yegor256 Any progress with this one? It's hanging as closed in my agenda for more than a month, but stilll some work is going around.

yegor256 commented 5 years ago

@paulodamaso what about keys? Can you put this table into JSON format, where all other tables are?

paulodamaso commented 5 years ago

@yegor256 please take a look at https://github.com/yegor256/wring/pull/89

paulodamaso commented 5 years ago

@yegor256 ping

ypshenychka commented 5 years ago

@paulodamaso Looks like PR is merged. Please proceed with closing this ticket then.

paulodamaso commented 5 years ago

@ypshenychka The ticket is already closed and was remoed from scope in https://github.com/yegor256/wring/issues/83#issuecomment-440917725 , but it was closed by mistake, without the proper resolution, which came only in https://github.com/yegor256/wring/pull/89 . So I think that you have to do the QA revision of this issue now.

ypshenychka commented 5 years ago

@paulodamaso you're right. Thanks

ypshenychka commented 5 years ago

@0crat quality good

0crat commented 5 years ago

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

0crat commented 5 years ago

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

0crat commented 5 years ago

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

0crat commented 5 years ago

Quality review completed: +8 point(s) just awarded to @ypshenychka/z