Closed paulodamaso closed 5 years ago
@0crat status
@0crat assign @pinaf
@carlosmiranda Would you kindly review and merge this one? This task is preventing me from receiving another tasks due to a full agenda, and I have submitted it almost a month ago.
@carlosmiranda ping
@carlosmiranda Done, please take a look
@rultor merge
@rultor merge
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@carlosmiranda Done! FYI, the full log is here (took me 18min)
Code review was too long (20 days), architects (@carlosmiranda) were penalized, see §55
There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@041da5f8-f9e0-45ec-8176-7f0140d878bb, thread: AsyncProc-4
com.zerocracy.farm.reactive.StkRuntime[76] java.lang.IllegalStateException: org.codehaus.groovy.runtime.InvokerInvocationException in com.zerocracy.stk.pm.cost.funding.send_zold
org.codehaus.groovy.reflection.CachedMethod[105] org.codehaus.groovy.runtime.InvokerInvocationException: groovy.lang.MissingMethodException: No signature of method: com.zerocracy.pmo.banks.Zold.pay() is applicable for argument types: (java.lang.String, com.zerocracy.cash.Cash$S, java.lang.String) values: [carlosmiranda, $5.00, none]
Possible solutions: pay(java.lang.String, com.zerocracy.cash.Cash, java.lang.String, java.lang.String), any(), wait(), find(), dump(), grep()
org.codehaus.groovy.runtime.ScriptBytecodeAdapter[71] groovy.lang.MissingMethodException: No signature of method: com.zerocracy.pmo.banks.Zold.pay() is applicable for argument types: (java.lang.String, com.zerocracy.cash.Cash$S, java.lang.String) values: [carlosmiranda, $5.00, none]
Possible solutions: pay(java.lang.String, com.zerocracy.cash.Cash, java.lang.String, java.lang.String), any(), wait(), find(), dump(), grep()
0.39.6: CID: 726ac397-e362-4f6a-beb9-4878cf41cb55, Type: "Send zold"
@0crat status
@carlosmiranda According to our QA Rules:
The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.
Only one issue was found during code review. Please confirm that you'll try to find at least three major problems while future reviews.
@ypshenychka this wasn't assigned to any reviewer for funding reasons, so quality should be "bad"
@carlosmiranda got it, thanks
@0crat quality bad
For #82: Introduce deletion of errors.
TkErrorDelete
endpoint for error deletion;TkErrorDelete
inTkApp
;TkErrors.source
method;DyErrorITCase
/DyErrorsITCase
tests